.. _important-unordered-queries-order-by-uid:

=====================================================
Important: Unordered profile queries now order by uid
=====================================================

Description
===========

Five query paths of this extension executed without any ordering, so the order
of their result was whatever the database happened to yield:

*   :php:`ProfileRepository::findAll()`
*   :php:`ProfileRepository::findByDemand()` whenever the demand yields no
    ordering — which is what the list plugin's :guilabel:`Sort by` option
    :guilabel:`none` means
*   :php:`LocationRepository::findAll()`,
    :php:`FunctionTypeRepository::findAll()` and
    :php:`OrganisationalUnitRepository::findAll()`, which fill the location,
    function type and organisational unit selects of the contract form in
    :php:`academic_persons_edit`

All five now order by :sql:`uid` ascending when nothing else asks for an
order.

Impact
======

No visible change is expected. Every supported database returned insertion
order for these queries in practice, and :sql:`uid` ascending is that same
order — the assertions of the affected functional tests are unchanged, they
are simply guaranteed now rather than coincidental.

What changes is that the order is reproducible. It previously depended on the
database, its version and which indexes existed, and could therefore change
under an installation without any content change. That is not hypothetical:
making the person tables workspace aware in the same release added an index
over :sql:`t3ver_oid`, which gave the PostgreSQL planner a way to satisfy the
:sql:`t3ver_oid = 0` constraint Extbase adds for a workspace aware table, and
reversed the result of exactly these queries.

The TCA :php:`default_sortby` of the location, function type and organisational
unit tables still does **not** apply to their :php:`findAll()`. That was never
the case and is not changed here — it orders the record lists of the backend,
not the selects of the frontend edit form.

Affected Installations
======================

Every installation of this extension. An installation that already sets a
sorting on the list plugin is unaffected either way, because an explicit
ordering always won.

.. index:: Frontend, PHP-API, ext:academic_persons