Breaking: The plugins call different repository finders 

Description 

The plugins hand the context they render in to the repositories, so that a listener of the new query events knows which plugin asked. Three finders are involved:

The two uid lookups keep their signature deliberately. Their callers now use findByUidsWithContext() next to them, which differs in nothing but the context it passes on; findByUids() delegates to it without one.

The context is \FGTCLB\AcademicBase\Domain\Model\Dto\PluginControllerActionContextInterface of academic_base, not the interface of the same name this extension ships. The latter extends the former since 3.0, see Breaking: The persons plugin action context extends the one of academic_base, and goes away in 4.0, so new API is typed against the shared one. The events of the controller actions are untouched.

Impact 

A subclass or XCLASS that overrides ProfileRepository::findByDemand() is a fatal error until it adds the parameter. PHP refuses an override with a narrower signature, so the installation breaks on the first request after the update rather than silently.

An override of either findByUids() keeps loading and stops being asked. The method is still there and still does what the override makes it do, but the selected-profiles and selected-contracts plugins do not go through it any more. Nothing reports this: the plugins simply render what the repository would have returned without the override.

Callers of the three finders that do not override them are unaffected — the new parameter has a default, and the two uid lookups did not change at all.

Affected Installations 

Installations whose own code extends ProfileRepository or ContractRepository , by a subclass registered as an Extbase repository or by an XCLASS. That is the shape the customizations of 2.x used to narrow what the plugins show, and it is what the query events replace.

Migration 

1. Add the parameter to an override of findByDemand() :

   public function findByDemand(
       DemandInterface $demand,
       ?PluginControllerActionContextInterface $context = null,
   ): QueryResultInterface {

   Copied!
2. Move what the override does to a listener of ModifyProfileQueryEvent or ModifyContractQueryEvent , and drop the override. A condition an override added to the query is a constraint the listener adds, and it then applies to every plugin instead of only the ones that happen to call the overridden method — pagination included.
3. An override of findByUids() has no other way back into the plugins. Either move it to a listener, or accept that it only serves the callers of that method.